fix(index): validate sortable columns before the first load #101

Merged

pienter merged 4 commits from fix/index-validate-before-load into main

2026-09-19 22:54:10 +00:00

pienter commented

2026-09-19 21:58:48 +00:00

Owner

Stacked on #100 (only because the worktree was; the change is independent of the block editor).

Index created its own query state — which loads immediately — before validating sortable columns against queryOptions.sorts, so an invalid configuration fired one request before throwing. Validation now runs first.

Play tests: Layout/Index Default and Invalid Sort Configuration were failing on main's line; expect.any(AbortSignal) throws in the browser runner (replaced by a shape check) and the row checkbox label is Select <first cell> now.

Checks: typecheck, lint, format, bun test (139), Index + DataTable play tests (25) green.

Stacked on #100 (only because the worktree was; the change is independent of the block editor). `Index` created its own query state — which loads immediately — before validating sortable columns against `queryOptions.sorts`, so an invalid configuration fired one request before throwing. Validation now runs first. Play tests: `Layout/Index` `Default` and `Invalid Sort Configuration` were failing on main's line; `expect.any(AbortSignal)` throws in the browser runner (replaced by a shape check) and the row checkbox label is `Select <first cell>` now. Checks: typecheck, lint, format, bun test (139), Index + DataTable play tests (25) green.

pienter added 1 commit

2026-09-19 21:58:48 +00:00

fix(index): validate sortable columns before the first load

ci / typecheck (pull_request) Successful in 28s

Details

ci / lint (pull_request) Successful in 33s

Details

ci / format (pull_request) Successful in 33s

Details

ci / release (pull_request) Has been skipped

Details

84be53646e

Index created its query state, which loads at once, before checking the
columns against queryOptions.sorts, so a bad configuration fired one request
before throwing. Story play tests: a shape check for the abort signal
(expect.any(AbortSignal) throws in the browser runner) and the current
row-select label.

pienter referenced this pull request

2026-09-19 22:08:13 +00:00

feat(block-editor): edit the open block in a Sheet when narrow #104

pienter changed target branch from task/pienter-ui__block-editor-ux__add-picker to main

2026-09-19 22:48:47 +00:00

pienter added 1 commit

2026-09-19 22:49:23 +00:00

Merge branch 'main' into fix/index-validate-before-load

ci / typecheck (pull_request) Successful in 43s

Details

ci / lint (pull_request) Successful in 46s

Details